Backport ukmo ps45 bugfixes#38
Merged
Merged
Conversation
ukmo-juan-castillo
approved these changes
Feb 1, 2023
ukmo-juan-castillo
left a comment
ukmo-juan-castillo
left a comment
There was a problem hiding this comment.
Tested several configurations and everything works as expected: the configurations that were failing before are now working, and otherwise there is no change in results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Backport two bugfixes from the official develop branch to the UKMO PS45 operational branch.
Comprises fixes for:
@ukmo-juan-castillo can you please review and test this branch against your configs to make sure it is working correctly (the merge was not trivial due to the change from WW3 switches to
#ifdefdirectives).If all is well, I will merge it with the PS45-1.hotfixes branch.